Attributes on property groups
| From: | Nikita Popov | Date: | Tue, 22 Sep 2020 12:51:22 +0000 |
| Subject: | Attributes on property groups | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-111914@lists.php.net to get a copy of this message | ||
Hi internals,
Currently, placing an attribute on property (or constant) groups is not
allowed:
class Foo {
#[NonNegative]
public int $x, $y, $z;
}
// Fatal error: Cannot apply attributes to a group of properties
This is a case that was not explicitly mentioned in the RFC and we decided
to be conversative when landing the initial implementation.
However, this restriction seems pretty arbitrary to me, and I think we
should remove it. While there is some potential ambiguity as to whether the
attribute applies to all properties or only the first one, I think the
general expectation is that it should apply to all properties, just like
the property type does.
PR to allow this: https://github.com/php/php-src/pull/6186
Any thoughts on this?
Regards,
Nikita