Stream filter may loose final block of data
| From: | Christoph M. Becker | Date: | Tue, 06 Oct 2020 13:34:31 +0000 |
| Subject: | Stream filter may loose final block of data | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-112014@lists.php.net to get a copy of this message | ||
Hi all,
as outlined in bug #77069[1], a stream filter may loose (aka. skip) the
final data block. That bug report has some duplicates: #48725, #79984
and #77080.
Several weaks ago I made PR #6001[2] which would fix this issue, but I'm
not sure whether that change would violate the assumption that the
PSFS_FLAG_FLUSH_CLOSE flag will only ever be passed if no further data
is to be processed.
Could someone more proficient with the streams layer than I am please
clarify whether that is a valid assumption in the first place?
[1] <https://bugs.php.net/bug.php?id=77069>
[2] <https://github.com/php/php-src/pull/6001>
Thanks,
Christoph