Re: Preparing for PHP 8.0.0 GA

Hi Sara, On Tue, Nov 24, 2020 at 5:56 PM Sara Golemon <pollita@php.net> wrote: > On Tue, Nov 24, 2020 at 12:35 AM Dmitry Stogov <dmitrystogov@gmail.com> > wrote: > >> I finally fixed all the known JIT related issues and made the PHP-8.0 >> build "green". >> >> >> >> https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=13088&view=results >> >> Please, cherry-pick the following 5 commits into PHP-8.0.0. >> >> c8df28d276c25c6f5ad0f1ab2727804b32be8cfe >> c0d1dbcb432f65d09f1c88cc368aa89eb5f067f4 >> 4cf3da73839b1ef3ab1fc8f74aee3a00237ad6b5 >> 586ccfdfd5179336dcf3719577b8258e55e7d76e >> 337d2af6ca50a52864034446d863331cbc61885e >> >>> >>> > Hi Dmitry, that's great news. > > Given that the JIT is enabled by default, I'm tempted to add another RC > and delay the release. > As the person who did this work, can you reassure my worries and tell me > that's not needed? > The good news is that none of these commits look particularly complex. > I think, new RC is not necessary. These commits only affect JIT. They fix the recently found problems and don't show any degradation. Thanks. Dmitry. > > -Sara > > c8df28d276 Fixed 32-bit JIT > c0d1dbcb43 Fixed incorrect TRACE_FRAME_MASK_NESTED flag setting > 4cf3da7383 Keep value of register before possible side exit > 586ccfdfd5 Fixed use-after-free in PHPUnit tests > 337d2af6ca zend_jit_trace_stack_frame.stack can't be NULL >