Re: [RFC] Restrict $GLOBALS usage
| From: | Hans Henrik Bergan | Date: | Fri, 04 Dec 2020 11:59:04 +0000 |
| Subject: | Re: [RFC] Restrict $GLOBALS usage | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-112411@lists.php.net to get a copy of this message | ||
if this gets rid of a significant amount of implementation complexity
or runtime overhead, i'm all for it, and don't think i've ever seen
code like $GLOBALS = []; before,
given that it's technically a BC break, would have been nice as a
8.0.0 thing, but i hope it's small enough for an 8.x instead of
waiting for php9
On Fri, 4 Dec 2020 at 12:04, Nicolas Grekas
<nicolas.grekas+php@gmail.com> wrote:
>
> Hello Nikita,
>
>
> > I would like to propose the following RFC, which restricts certain rare
> > usages of $GLOBALS. This change will improve performance, reduce internal
> > implementation complexity, and fix a very large class of bugs relating to
> > $GLOBALS handling in internal functions.
> >
> > https://wiki.php.net/rfc/restrict_globals_usage
>
>
> Yes please! This will allow removing some black magic from Symfony's
> VarDumper component, which detects these "copies" of $GLOBALS:
>
> https://github.com/symfony/symfony/blob/31ee43a8c67897a2f61782060965f5c8a81f58a2/src/Symfony/Component/VarDumper/Cloner/VarCloner.php#L144-L1551
> 0yase'F
>
> Nicolas