Re: [VOTE] PHP\iterable\any() and all() on iterables

On Mon, Feb 8, 2021 at 7:33 AM tyson andre <tysonandre775@hotmail.com> wrote: > > Hi internals, > > Voting has started on > https://wiki.php.net/rfc/any_all_on_iterable and ends on 2021-02-22. > > This RFC proposes to add the functions PHP\iterable\any(iterable $input, > ?callable $callback = null): bool and > PHP\iterable\all(...) > to PHP's standard library's function set, using the namespace preferred in the > previous straw poll. > > There is a primary vote on whether to add the functions, and a secondary vote on the name to > use within the PHP\iterable namespace. > > Thanks, > - Tyson > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: https://www.php.net/unsub.php > Thanks for the RFC. I have voted no, even though I am very supportive of the direction. My objections are: - I think the scope is too small. This is introducing a new family of functions, but is only proposing two functions. This is too small to firmly root in good design and precedence. - I do not like the chosen namespace. This is not as important as the previous point, but still factored into my decision as we are still very early in choosing namespaces for internals. I don't want to vote for something I think is a bad direction when we're this early on. Again, I am supportive of adding these functions in some form, but I very strongly do not believe this RFC is what we should do. I tried to collaborate with Tyson more on these points but either we mis-communicated or he wasn't interested. In any case, it's up for a vote so I choose "no."