Re: [RFC] fsync function

Hi all, Giving this one a little bump as I haven't had any particular feedback or comments about it so far. I know it's not the biggest or most exciting change in the world but it's implemented and I'd like to progress it to a vote in another week or so if there are no objections or clarifications? To summarise: - Adds fsync() and fdatasync() for plain file streams on Unix systems. - Adds fsync() on Windows with fdatasync() as an alias. Thank you. RFC ref: https://wiki.php.net/rfc/fsync_function PR ref: https://github.com/php/php-src/pull/6650 -Dave On Wed, Feb 3, 2021 at 5:46 PM David Gebler <davidgebler@gmail.com> wrote: > RFC ref: https://wiki.php.net/rfc/fsync_function > PR ref: https://github.com/php/php-src/pull/6650 > > I think this one is pretty much good now and passing builds; when I first > proposed adding fsync some time ago, there was a suggestion from a couple > contributors that an RFC might be overkill/unnecessary for this feature > (and I'd certainly be happy for it to just be accepted as a pull request) > but want to make sure everyone has had a good chance to look over the RFC > and implementation and specifically whether anyone has any significant > concerns or objections? > > Thanks. > > Dave > > On Mon, Feb 1, 2021 at 5:35 PM David Gebler <davidgebler@gmail.com> wrote: > >> Hi internals, >> I have updated the GitHub PR and wiki RFC to also include an >> implementation of fdatasync. >> >> On another note, I note my PR builds are failing on MACOS_DEBUG_NTS with >> a test in ext/zend_test/tests/observer_error_05.phpt- this does not >> appear to be related to my changes and I'm wondering if anyone can shed >> any light on this? I'm seeing it on some other open PRs too so I'm guessing >> it's a known issue? Cheers. >> >> David Gebler >> davidgebler@gmail.com >> >> >> On Sat, Jan 30, 2021 at 6:34 PM David Gebler <davidgebler@gmail.com> >> wrote: >> >>> Updated the PR https://github.com/php/php-src/pull/6650 >>> following >>> comment from Nikita, added basic tests, would appreciate further review >>> from contributors, have updated the RFC >>> https://wiki.php.net/rfc/fsync_function to under >>> discussion, cheers. >>> >>> David Gebler >>> davidgebler@gmail.com >>> >>> >>> On Sat, Jan 30, 2021 at 1:58 AM David Gebler <davidgebler@gmail.com> >>> wrote: >>> >>>> Hi internals, >>>> Some time back I asked for commentary on a proposal to add fsync() to >>>> PHP, I have now submitted a draft RFC >>>> https://wiki.php.net/rfc/fsync_function alongside >>>> an in-progress proof >>>> of concept PR (current status: can compile locally and run but the branch >>>> needs more work to bring it up to standard, as well as tests and >>>> documentation) which I would like to open up for review and discussion. >>>> >>>> Thanks. >>>> >>>> David Gebler >>>> davidgebler@gmail.com >>>> >>>>