Re: Use MySQL syntax only for parsing MySQL statements in PDO

From:	Matteo Beccati	Date:	Sun, 11 Apr 2021 09:53:49 +0000
Subject:	Re: Use MySQL syntax only for parsing MySQL statements in PDO
References:	1	Groups:	php.internals
Request:	Send a blank email to internals+get-114020@lists.php.net to get a copy of this message

Hi Sergei,

in fact I have been working on a secret plan to allow each driver to optionally have their own parser. Due to very limited time I haven't finalised all the details, but the proof of concept looks promising:

https://github.com/php/php-src/pull/6852

Perhaps we could work together and come up with an RFC?


Cheers

On 10/04/2021 19:13, Sergei Morozov wrote:
Hi Internals,

There are bugs #79276 <https://bugs.php.net/bug.php?id=79276> and #80340
<https://bugs.php.net/bug.php?id=80340> where PDO parses valid PostgreSQL
statements incorrectly because it uses MySQL grammar for all statements
regardless of the underlying platform.

I submitted pull request #6410 <https://github.com/php/php-src/pull/6410> which
enables extensions to opt-in to MySQL-specific syntax (since it's not
standard). Currently only pdo_mysql uses it.

As Christoph Becker suggested, I'm bringing it here for discussion.

Technically, it may be a BC break since there may exist PDO-based
extensions outside the PHP repository that rely on compatibility with the
MySQL syntax.

Are there known extensions like this? Would this change be acceptable in
one of the next minor releases?

Regards,
Sergei Morozov



-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/


   

Thread (7 messages)

• Sergei MorozovSat, 10 Apr 2021 17:13:12 +0000
  • Kamil TekielaSat, 10 Apr 2021 22:33:41 +0000
    • Sergei MorozovSun, 11 Apr 2021 00:41:40 +0000
      • Kamil TekielaSun, 11 Apr 2021 15:28:57 +0000
        • Sergei MorozovSun, 11 Apr 2021 17:48:59 +0000
          • Matteo BeccatiMon, 12 Apr 2021 06:00:06 +0000
  • Matteo BeccatiSun, 11 Apr 2021 09:53:49 +0000