Re: Rename Fiber::this() to Fiber::getCurrent()

From: Date: Tue, 15 Jun 2021 19:53:48 +0000
Subject: Re: Rename Fiber::this() to Fiber::getCurrent()
References: 1  Groups: php.internals 
Request: Send a blank email to internals+get-114894@lists.php.net to get a copy of this message 
On Tue, Jun 15, 2021, at 2:01 PM, Aaron Piotrowski wrote:
> Hi all,
> 
> During the Fiber RFC vote, several people noted that they objected to 
> the name Fiber::this() for the method returning the currently executing 
> Fiber object.
> 
> I'd like to propose renaming this method to Fiber::getCurrent(). A 
> simple PR for the rename: https://github.com/php/php-src/pull/7155
> Nothing has functionally changed about the method, only the name.
> 
> Fiber::current() is another possibility, but was not chosen because it 
> may be conflated with Iterator::current().
> 
> Does anyone object to this rename? Shall we have a vote or is that not 
> necessary?
> 
> Cheers,
> Aaron Piotrowski

I support this change, and don't think it needs an RFC.  I would vote for it if it were
necessary, though.

--Larry Garfield

Thread (3 messages)

« previous php.internals (#114894) next »