Re: cvs: php-src /ext/dom php_dom.c

Hello internals, wez also uses this in com_dotnet so this may become a standard habit. Should i provide a standard implementation for it? regrads marcus Sunday, July 25, 2004, 8:50:26 PM, you wrote: > helly Sun Jul 25 14:50:26 2004 EDT > Modified files: > /php-src/ext/dom php_dom.c > Log: > - Fixed Bug #29354 Exception constructor marked as both public and > protected > # If the constructor should be protected then it needs to be overwritten > # with a method that simply calls the parent, this function simply changes > # the visibility of the original function and makes that (public+protected) > > http://cvs.php.net/diff.php/php-src/ext/dom/php_dom.c?r1=1.60&r2=1.61&ty=u > Index: php-src/ext/dom/php_dom.c > diff -u php-src/ext/dom/php_dom.c:1.60 php-src/ext/dom/php_dom.c:1.61 > --- php-src/ext/dom/php_dom.c:1.60 Tue Jun 15 07:50:56 2004 > +++ php-src/ext/dom/php_dom.c Sun Jul 25 14:50:24 2004 > @@ -18,7 +18,7 @@ > > +----------------------------------------------------------------------+ > */ > -/* $Id: php_dom.c,v 1.60 2004/06/15 11:50:56 rrichards Exp $ */ > +/* $Id: php_dom.c,v 1.61 2004/07/25 18:50:24 helly Exp $ */ > #ifdef HAVE_CONFIG_H > #include "config.h" > @@ -384,7 +384,6 @@ > INIT_CLASS_ENTRY(ce, "DOMException", > php_dom_domexception_class_functions); > dom_domexception_class_entry = zend_register_internal_class_ex(&ce, > zend_exception_get_default(), NULL TSRMLS_CC); > dom_domexception_class_entry->ce_flags |= ZEND_ACC_FINAL; > - dom_domexception_class_entry->constructor->common.fn_flags |= ZEND_ACC_PROTECTED; > zend_declare_property_long(dom_domexception_class_entry, "code", > sizeof("code")-1, 0, ZEND_ACC_PUBLIC TSRMLS_CC); > REGISTER_DOM_CLASS(ce, "DOMStringList", NULL, > php_dom_domstringlist_class_functions, dom_domstringlist_class_entry); -- Best regards, Marcus mailto:helly@php.net