Re: [PATCH] bug #29336
| From: | Sascha Schumann | Date: | Mon, 26 Jul 2004 07:58:01 +0000 |
| Subject: | Re: [PATCH] bug #29336 | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-11567@lists.php.net to get a copy of this message | ||
On Mon, 26 Jul 2004, Antony Dovgal wrote:
Hi all! Plz, take a look at bug #29336 ( http://bugs.php.net/29336 for lazy ones =)). HEAD segfaults on session_start() after empty_string -> STR_EMPTY_ALLOC() change. This happens because SID constant gets initialized with "" string instead of STR_EMPTY_ALLOC(). The patch: http://tony2004.phpclub.net/dev/tmp/session.diff seems to be the solution.
The second part regarding session.c is ok.
Another one issue, that is being fixed by this patch, is false memory leak message ("Freeing 0 bytes blah-blah"), similar to this: http://lists.php.net/php.zend-engine.cvs/2796 issue.
The read process should just be skipped, if the file has zero
length. I'll look into this later this day.
- Sascha