Re: [RFC] [VOTE] is_literal
| From: | Craig Francis | Date: | Tue, 14 Sep 2021 14:53:21 +0000 |
| Subject: | Re: [RFC] [VOTE] is_literal | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-116043@lists.php.net to get a copy of this message | ||
On Wed, 8 Sept 2021 at 09:32, Stephen Reay <stephen@koalephant.com> wrote:
> I had my share of issues with Craig’s PR, but I think the original goal of
> it was a good and useful concept
Thanks Stephen,
Just to confirm to others on-list... your "share of issues" was when we
looked at allowing all Integers, and you "would have been happy with
original/final implementation with strings only"... also, I agree with "A
type hint would be a great addition too".
For those who missed the original discussion... unlike strings, we cannot
flag if an integer was defined by the developer (in the PHP script); and
because integers cannot cause Injection Vulnerabilities (the pure
definition), I decided to allow all integers (to help adoption). But, with
my naming mistake (trying to better reflect that behaviour), and people
finding it a messy concept, we ended up removing integer support.
Craig