Re: Proposal: &$result_code=null parameter in shell_exec()

On Thu, Nov 18, 2021 at 8:47 AM Luca Petrucci via internals < internals@lists.php.net> wrote: > Hi internals, > > This is a proposal to add an optional parameter &$result_code = null to > the shell_exec() function. > > For clarity, the current signature is > shell_exec(string $command): string|false|null > The proposed signature is > shell_exec(string $command, int &$result_code = null): string|false|null > > If present, the result_code parameter is set to the exit code of the > command, as it is in exec() and system(). > > This feature request was also posted by another user on > https://bugs.php.net/bug.php?id=81493 > I have a draft pull request at > https://github.com/php/php-src/pull/7663 > > Thoughts? > > Thanks, > Luca > This looks like a reasonable addition to me. Between shell_exec(), system(), passthru() and exec(), shell_exec() is the only function that doesn't currently accept a $result_code parameter, so including it makes sense for consistency. Regards, Nikita