Re: RFC [Discussion]: Redacting parameters in back traces
| From: | Tim Düsterhus, WoltLab GmbH | Date: | Tue, 11 Jan 2022 09:28:40 +0000 |
| Subject: | Re: RFC [Discussion]: Redacting parameters in back traces | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-116866@lists.php.net to get a copy of this message | ||
Hi Alex
On 1/11/22 4:10 AM, Alexandru Pătrănescu wrote:
As the trace in the exception is in the same format as the one generated by debug_backtrace(), do you intend to have the changes affecting debug_backtrace() and debug_print_backtrace()?My proof of concept patch adjusts the internal 'debug_backtrace_get_args' function which the function that collects the function parameters whenever a back trace is generated (Exceptions, debug_backtrace, debug_print_backtrace). I've added a new example showing debug_backtrace to the RFC.
Also, globally configuring generated exception traces to not include parameters would solve the issue? I mean, similarly with how DEBUG_BACKTRACE_IGNORE_ARGS works?This is already configurable with 'zend.exception_ignore_args'. There's a section in the RFC why we believe this to not be a solution: https://wiki.php.net/rfc/redact_parameters_in_back_traces#why_existing_features_are_insufficient Best regards Tim Düsterhus Developer WoltLab GmbH -- WoltLab GmbH Nedlitzer Str. 27B 14469 Potsdam Tel.: +49 331 96784338 duesterhus@woltlab.com www.woltlab.com Managing director: Marcel Werk AG Potsdam HRB 26795 P