Re: [RFC] Undefined Variable Error Promotion

On 23.02.2022 at 16:29, Nicolas Grekas wrote: > Le mar. 22 févr. 2022 à 14:56, Marco Pivetta <ocramius@gmail.com> a écrit : > >> On Tue, Feb 22, 2022 at 2:53 PM Nicolas Grekas < >> nicolas.grekas+php@gmail.com> wrote: >> >>> But this makes me think: we should trigger a deprecation just before all >>> corresponding warnings! >> >> Please, no more deprecation warnings, make it stop 😥 >> Yes, undefined variables are a problem, but I just spent 6 months in >> vendor/ code for 8.0->8.1 stuff, and it doesn't >> bring anything but >> frustration: this stuff is statically introspectible, and even more >> side-effects are just more trouble. > > I'm not going to be affected by this RFC at all, and neither are you, since > we use throwing error handlers. But ppl that do rely on code bases that > have undefined vars "by design" will be. I would bet that the number of ppl > in that affected group and that also use a static analyser is very very > small. This means that static analysers are not a pragmatic solution here. That. > Ppl that don't use static analysers deserve a prior notice. There is a > dedicated reporting mechanism in place and we should use it IMHO. With new > deprecations added to PHP 8.1, the ecosystem realized that the tooling > needed to improve - and it did (phpunit, Laravel, etc.). We can and should > add new runtime deprecations when planning a BC break. > > Please consider adding this deprecation Mark (and others.) Do you mean E_DEPRECATED in addition to E_WARNING, or instead? I wouldn't be happy either way. -- Christoph M. Becker