Re: [RFC] [Vote] Pre-vote announcement for Random Extension 5.x

2022年6月4日(土) 18:03 Côme Chilliet <come@chilliet.eu>: > Le 31 mai 2022 11:54:18 GMT+02:00, Go Kudo <g-kudo@colopl.co.jp> a écrit : > >Hi internals. > > > >Although I have explained that due to the global turmoil I will delay > >voting on the RFC as long as possible, it is time to start voting on the > >RFC in order to get the implementation to full status by the PHP 8.2 > >Feature Freeze. > > > >I apologize for the delay in responding to the points you had already > >pointed out. It has been addressed as follows. > > > >- Random\Engine\PCG64::__construct() now takes an > >int|string $inc as its > >second argument > > - This makes it fully compatible with the PCG64 original > implementation > >- Fixed an algorithm implementation error in PCG64 > >- Fixed compatibility issues with PHP 8.2 in test cases > >- More detailed description in RFC > > > >Previous discussion thread: > >https://externals.io/message/117295 > > > >Voting will begin at 2022-06-14 00:00:00 (UTC). > > > >https://wiki.php.net/rfc/rng_extension > > > >Regards, > >Go Kudo > > The first section starts with "However", which sounds like an error from a > text reorganization? > Also: > "adding any randomization functions between the seeding the intended usage > would break the code. " -> missing "and" I suppose > "Even with JIT enabled, the native implementation is not far behind. " -> > it *is* far behind no? It's not even behind but ahead as I see it so maybe > I just misunderstand this comment. > > Côme > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: https://www.php.net/unsub.php > > > The first section starts with "However", which sounds like an error from a text reorganization? > "adding any randomization functions between the seeding the intended usage would break the code. " -> missing "and" I suppose Thanks, I fixed it. > "Even with JIT enabled, the native implementation is not far behind. " -> it *is* far behind no? It's not even behind but ahead as I see it so maybe I just misunderstand this comment. Just wanted to explain that the native implementation is faster. (C > PHP) I changed it to a more clear form. (I was replying directly to you. sorry)