Re: Discussion about new Curl URL API and ext/curl improvements
| From: | Pierrick Charron | Date: | Mon, 20 Jun 2022 21:59:12 +0000 |
| Subject: | Re: Discussion about new Curl URL API and ext/curl improvements | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-118026@lists.php.net to get a copy of this message | ||
>
>
> I haven't read back through the thread, but my impression was that *for
> the curl URL facility specifically* the opposite was the case: a simple
> object with no procedural equivalent would be everyone's preference.
> CurlFile provides enough of a precedent for adding that IMO.
>
+1
>
> Either way, we have to agree on some naming details, so I've left some
> comments on the PR.
>
>
Your suggested names were good, so I used them except for
NON_SUPPORT_SCHEME that I replaced with ALLOW_UNSUPPORTED_SCHEME.
> (By the way, the PR you linked is to merge into your own fork's master,
> not the actual central php-src repo. Not sure if that was deliberate.)
>
I didn't do it intentionally. Sorry about that.
Regards
Pierrick