Re: Re: [RFC] [Under Discussion] PDO driver specific sub-classes
| From: | Rowan Tommins | Date: | Fri, 24 Jun 2022 16:23:32 +0000 |
| Subject: | Re: Re: [RFC] [Under Discussion] PDO driver specific sub-classes | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-118090@lists.php.net to get a copy of this message | ||
On Fri, 24 Jun 2022 at 16:38, Dan Ackroyd <Danack@basereality.com> wrote:
> YAGNI, and I'm lazy. But mostly, I don't think adding them now
> actually helps achieve anything.
>
Fair enough, but as a minimum there should be an internal API for
registering a sub-class, without any modification to ext/pdo.
For instance, it should be possible to modify
https://github.com/microsoft/msphpsql to define
a PDOSqlServer class and
have it returned by PDO::connect when a relevant DSN is provided.
It looks like the current PR implements everything directly in ext/pdo,
which feels like a broken abstraction; the SQLite-specific functionality
should all live in ext/pdo_sqlite.
Regards,
--
Rowan Tommins
[IMSoP]