Re: Adding the OpenSSF Scorecards GitHub Action
| From: | Tim Düsterhus | Date: | Fri, 28 Oct 2022 17:37:50 +0000 |
| Subject: | Re: Adding the OpenSSF Scorecards GitHub Action | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-118904@lists.php.net to get a copy of this message | ||
Hi
as a heads up: Please do not top post (as per https://github.com/php/php-src/blob/master/docs/mailinglist-rules.md). Your previous replies were already correct.
On 10/28/22 19:11, Pedro Nacht via internals wrote:
And if there's interest, I'll happily fix that small inconsistency in the labeler.yml permissions.I obviously can't speak for the others, but I am interested for as I said in my first reply. Consistency is good, if it makes some automated scanner happy to prevent users from asking about the results in the future, even better. So yes, please send a PR. I'd also say: Feel free to also send PRs for other stuff in the future. A PR that actually *fixes* some obvious issue or improves something without a drawback should generally be well-received. In fact that's how the action permissions config was introduced in the first place - by an non-core contributor: https://github.com/php/php-src/pull/9440 Best regards Tim Düsterhus