Re: Adding strtotime change to migration document

On 11.01.2023 at 15:19, Christian Schneider wrote: > Am 11.01.2023 um 15:04 schrieb Christoph M. Becker <cmbecker69@gmx.de>: >> On 11.01.2023 at 14:07, Christian Schneider wrote: >> >>> While migrating to PHP 8.2 we noticed the change in strtotime. >>> PHP <= 8.1 supported "today +- 3 days" etc. but the support for multiple >>> sign characters (++, --, -+, +-) has been removed in 8.2: >>> https://3v4l.org/mHa3t >>> >>> This was discussed at >>> >>> https://github.com/php/php-src/issues/9950#issuecomment-1314101723 >>> >>> I understand the reasoning to remove support even though I liked the flexibility but as >>> this is a small BC break I was wondering if it should be added to the migration document for 8.2. >> >> Given that PHP itself has no problems with this >> (<https://3v4l.org/8WBEj>), I think a changelog entry >> is appropriate. >> Maybe you want to provide a respective PR? > > I'm not familiar with the changelog / migration document handling but my preferred place > would be a line in the migration document so people checking what they have to look out for > hopefully see it. I don't think people read the full changelogs. Documented as <https://github.com/php/doc-en/commit/cf220d0944b207510abb5e3c7c262140b8ac082c>. -- Christoph M. Becker