Re: cvs: php-src(PHP_5_0) / README.CVS-RULES

Hello, Who made this decision?? On Thu, 05 Aug 2004, Antony Dovgal wrote: > tony2001 Thu Aug 5 10:19:59 2004 EDT > > Modified files: (Branch: PHP_5_0) > /php-src README.CVS-RULES > Log: > MFH: remove all references to @ thing, as it's not recommended > > > > http://cvs.php.net/diff.php/php-src/README.CVS-RULES?r1=1.16&r2=1.16.14.1&ty=u > Index: php-src/README.CVS-RULES > diff -u php-src/README.CVS-RULES:1.16 php-src/README.CVS-RULES:1.16.14.1 > --- php-src/README.CVS-RULES:1.16 Thu Oct 31 10:06:18 2002 > +++ php-src/README.CVS-RULES Thu Aug 5 10:19:59 2004 > @@ -37,8 +37,11 @@ > messages every day. Woe be to those who attempt to mess with it. > > 2. All news updates intended for public viewing, such as new features, > - bug fixes, improvements, etc., should go into the NEWS file. Also see > - the note below about automatically updating NEWS in your commit message. > + bug fixes, improvements, etc., should go into the NEWS file. > + > + NB! Lines, starting with @ will go automagically into NEWS file, but > + this is NOT recommended, though. Please, add news entries directly to > + NEWS file and don't forget to keep them adjusted and sorted. > > 3. Do not commit multiple file and dump all messages in one commit. If you > modified several unrelated files, commit each group separately and > @@ -59,14 +62,10 @@ > The format of the commit messages is pretty simple. > > If a line begins with #, it is taken to be a comment and will not appear > -in the ChangeLog. If the line begins with @, it will be redirected to the > -NEWS file. Everything else goes into the ChangeLog. > +in the ChangeLog. Everything else goes into the ChangeLog. > > It is important to note that if your comment or news logline spans multiple > -lines, you have to put # or @ at the beginning of _every_ such line. Every > -entry in NEWS has to have a name after it, so if you did it with someone's > -help, put both your names there. Your name WILL NOT be automatically put > -at the end of the NEWS entry - so, please provide it yourself. > +lines, you have to put # at the beginning of _every_ such line. > > Example. Say you modified two files, datetime.c and string.c. In datetime.c > you added a new format option for date() function, and in string.c you fixed > @@ -78,17 +77,12 @@ > > (PHP date) Added new 'K' format modifier for printing out number of > days until New Year's Eve. > -@- Added new 'K' format modifier that will output the number of days > -@ until New Year's Eve. (Bob) > > For string.c: > (php_trim) Fixed a memory leak resulting from improper use of zval_dtor(). > # Man, that thing was leaking all over the place! > -@- Fixed memory leak in trim(). (Bob) > > -The lines above marked with @ will go into NEWS file automagically, and the > -# lines will be omitted from the ChangeLog. Alternatively, you might want > -to modify NEWS file directly and not use the @ lines. > +The # lines will be omitted from the ChangeLog automagically. > > If you fix some bugs, you should note the bug ID numbers in your > commit message. Bug ID should be prefixed by "#" for easier access to > @@ -97,12 +91,10 @@ > Example: > > Fixed pgsql notice handler double free crash bug. Bug #14016 > -@ Fixed pgsql notice handler double free crash bug. Bug #14016 > > -If you don't see your messages in ChangeLog and NEWS right away, don't worry! > +If you don't see your messages in ChangeLog right away, don't worry! > These files are updated once a day, so your stuff will not show up until > -somewhat later. Don't go adding stuff to NEWS by hand if you already put @ > -lines in the commit message. > +somewhat later. > > You can use LXR (http://lxr.php.net/) and Bonsai (http://bonsai.php.net/) > to look at PHP CVS repository in various ways. > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php -Andrei * We reason deeply, when we forcibly feel. *