Re: Everyone on the road?
| From: | Rasmus Lerdorf | Date: | Fri, 06 Aug 2004 21:12:45 +0000 |
| Subject: | Re: Everyone on the road? | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-11977@lists.php.net to get a copy of this message | ||
On Fri, 6 Aug 2004, Andi Gutmans wrote:
> If you call it get_request_start_time() it should make it clearer what it
> means.
> I guess we could put it into SAPI I don't see any disadvantage although in
> any case, doing it one more time per-request wouldn't be that bad either.
> I hope to have more time towards the end of next week and then I can
> hopefully make this improvement.
Sure, it's a single syscall, but this entire effort is about removing
syscalls, so adding one that isn't necessary because it has already been
done during the request makes sense.
I am just cleaning up some other code where a sapi call for this would
make things a lot cleaner. Without the sapi call you end up needing to do
this:
#if HAVE_APACHE
#include "httpd.h"
#endif
...
#if HAVE_APACHE
t = ((request_rec *)SG(server_context))->request_time;
#else
t = time(0);
#endif
-Rasmus