Re: [PATCH] fix symbol namespace pollution from bundled libgd

On Mon, Aug 09, 2004 at 09:46:21AM +0200, Edin Kadribasic wrote: > On Monday 09 August 2004 09:00, Derick Rethans wrote: > > On Sat, 7 Aug 2004, Joe Orton wrote: > > > That would mean adding exactly the reverse set of #defines to allow the > > > the GD extension to be built against an external copy of libgd (which of > > > course won't use the phpgd_* symbols). > > > > > > Given that a complete set of #defines is needed anyway, doing it without > > > modifying libgd makes more sense since it's then easier to track the > > > upstream libgd sources. > > > > Right ;-) Can you please update your patch with the new symbols then? > > I'll commit it then later (or just ask for a CVS account!) > > I'm -1 on this patch. The problem is has existed for mysql lib for ages and > for all other libraries used by PHP. For all other libraries *which are bundled with PHP*, not just *used* by PHP. Why are the php_compat.h #defines acceptable to fix this issue for PCRE and expat, but not for libgd? > A note in the documentation stating that > if you want to use GD from PHP and another Apache module you need to compile > PHP with the external library should be sufficient. This would be a reasonable argument if the libgd bundled with PHP was exactly the same as the upstream libgd, but that's not the case, the libgd bundled with PHP is extensively modified. joe