Re: [RFC] [Discussion] Deprecate functions with overloaded signatures
| From: | Máté Kocsis | Date: | Tue, 13 Jun 2023 14:49:53 +0000 |
| Subject: | Re: [RFC] [Discussion] Deprecate functions with overloaded signatures | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-120562@lists.php.net to get a copy of this message | ||
>
> It looks like the current preferred signature was only introduced in PHP
> 8.2. Previously, the signatures were dba_fetch($key, $handle) and
> dba_fetch($key, $skip, $handle) - it effectively had a non-final optional
> parameter.
>
Yes, that's the case! Thanks for reminding me again, I clarified in the RFC
that PHP 8.2 is the first version which supports the preferred signature.
> Whether that makes it too early to deprecate the older 3-parameter form,
> I'm not sure. As you say, it's probably pretty rare, particularly because
> according to the docs that parameter is ignored for most file formats the
> function supports anyway.
>
Normally, I wouldn't do this, but I'm certain that deprecating this
signature won't cause a big havoc in the PHP ecosystem, so that's the only
reason I went ahead.
>