Adding $before_needle argument to strrchr()
| From: | Berislav | Date: | Sun, 25 Jun 2023 12:00:09 +0000 |
| Subject: | Adding $before_needle argument to strrchr() | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-120674@lists.php.net to get a copy of this message | ||
Hi internals,
I was told to ask for your feedback regarding the following PR I've opened:
https://github.com/php/php-src/pull/11430.
The PR adds a $before_needle argument to strrchr() that allows returning
part of the haystack before the occurrence of the needle. Similar functions
such as strstr(), stristr() or its mb counterpart mb_strrchr() already have
this option, strrchr() seems to be the only one without it.
According to Jakub Zelenka, if no one objects, the PR can get merged.
Best regards,
Berislav