Re: Introducing 2 new modes to round function
| From: | Marco Pivetta | Date: | Fri, 21 Jul 2023 19:38:03 +0000 |
| Subject: | Re: Introducing 2 new modes to round function | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-120857@lists.php.net to get a copy of this message | ||
Hey Jorg,
What is the reason for using this over these?
* https://www.php.net/manual/en/function.ceil.php
* https://www.php.net/manual/en/function.floor.php
On Fri, 21 Jul 2023, 21:26 Jorg Sowa, <jorg.sowa@gmail.com> wrote:
> Hello internals!
>
> I would like to propose introducing two new modes to the function
>
round(): PHP_ROUND_DOWN and PHP_ROUND_UP.
>
> Those modes are highly requested as you can see by the comments on round
> documentation page. First comment mentioning about those modes has 309
> votes as of today. Introducing those 2 modes would be complementing to the
> rounding in this function.
>
> Round documentation:
> https://www.php.net/manual/en/function.round.php
> My implementation: https://github.com/php/php-src/pull/11741
>
> I'm not sure if such minor improvement requires RFC, but as someone may
> have some concerns I create this thread to get your feedback.
>
> Kind regards,
> Jorg
>