Re: New reflection methods for working with attributes
| From: | Robin Chalas | Date: | Thu, 03 Aug 2023 18:40:38 +0000 |
| Subject: | Re: New reflection methods for working with attributes | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-120879@lists.php.net to get a copy of this message | ||
> In that case, are you happy for me to PR the other two methods I suggested, or would you like
> to handle that?
Please go ahead! Thanks for caring.
And if you already have the patch ready for hasAttribute() too but just care enough to leave it to
the wanna-be-first-time-contributor that I am, please consider sharing it to me so that I can
compare with what I have once I’m back from vacation next week (and either come back to you with
questions or incline myself :)). Or I’ll send you mine for early review when I’m back to
keyboard if you’re ok.
Cheers
-- Robin Chalas
Le 3 août 2023 à 20:20 +0200, Ollie Read <php@ollie.codes>, a écrit :
>
> > Alright, I will just ship the PR for
hasAttribute() then.
> > Thanks for the hints and feedback.
> > And sorry for the bad posting style, I hope this one is ok.
>
> In that case, are you happy for me to PR the other two methods I suggested, or would you like
> to handle that?
>
> ---
> Best Regards,
> *Ollie Read*