Re: Change default method of disabling JIT for PHP 8.4
| From: | Daniil Gentili | Date: | Wed, 18 Oct 2023 08:42:38 +0000 |
| Subject: | Re: Change default method of disabling JIT for PHP 8.4 | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-121374@lists.php.net to get a copy of this message | ||
Hi,
This is precisely why I'm planning to submit the RFC to make the change in PHP 8.4, which is when the new JIT will be introduced.
Regards,
Daniil.
On 10/18/23 08:52, Christian Schneider wrote:
Am 17.10.2023 um 19:46 schrieb Daniil Gentili <daniil@daniil.it>:I would like to submit an RFC and PR to change a few INI defaults for opcache, changing how JIT is disabled by default. Currently, JIT is disabled by default using the |opcache.jit_buffer_size=0| default, instead of |opcache.jit=0|. I would like to change these defaults to: - opcache.jit=off - opcache.jit_buffer_size=64m (taken from https://github.com/php/php-src/pull/12425/files, any smaller multiple of 2 causes the buffer to fill up when running moderately sized projects like Psalm or PHPStan).I understand your point but it might unexpectedly switch behavior for people just setting jit_buffer_size and expecting this to turn JIT on. While (in the light of a new upcoming JIT) this might not be a big deal it is also not clear if it is worth it. Maybe the settings can be overhauled once the new JIT is introduced (which might have different settings anyway). Regards, - Chris