Re: Set register_argc_argv to Off by default
| From: | Thomas Chauchefoin via internals | Date: | Wed, 08 Nov 2023 16:58:42 +0000 |
| Subject: | Re: Set register_argc_argv to Off by default | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-121620@lists.php.net to get a copy of this message | ||
On Tue, Nov 7, 2023 at 11:46 AM Sebastian Bergmann <sebastian@php.net> wrote:
> Am 07.11.2023 um 11:33 schrieb Thomas Chauchefoin via internals:
> > For instance, the official Docker image has it on [2].
>
> "Official" is relative here. That image is maintained by (the) Docker
> (community), it is not maintained by the PHP project.
Indeed, my bad. I've updated the GitHub issue to reflect that this
Docker image is not maintained by the PHP project.
On Tue, Nov 7, 2023 at 2:12 PM Kévin Dunglas <kevin@dunglas.fr> wrote:
> This change seems reasonable to me: safer, with little chance of breaking
> things, and easy to reverse for the end user by changing a single parameter.
On Tue, Nov 7, 2023 at 5:33 PM Matteo Beccati <matteo@beccati.com> wrote:
> Seriously though, I do agree with changing the default. I believe such
> check was added in a time when it was still common to use the cgi
> executable to run cli commands and the configuration was shared with
> mod_php.
On Tue, Nov 7, 2023 at 4:48 PM G. P. B. <george.banyard@gmail.com> wrote:
> This sounds sensible to me.
Thank you for your early feedback on this suggestion. Without rushing
things, I assume that the next step for me would be to draft an RFC to
formalize this change?
Best,
-Thomas