Re: [VOTE] [RFC] Final anonymous classes

On Sun, Dec 3, 2023, at 10:34 AM, Derick Rethans wrote: > On 3 December 2023 14:49:12 GMT, Nikita Popov <nikita.ppv@gmail.com> wrote: >>On Sun, Dec 3, 2023, at 11:40, Daniil Gentili wrote: >>> Hi all, >>> >>> I've just opened voting for the final anonymous classes RFC @ >>> https://wiki.php.net/rfc/final_anonymous_classes. >>> >>> Voting started now, and will run until December 18th 2023, 00:00 GMT. >> >>For the record, I've voted against this proposal because I believe it should have gone >>with option 2, that is to *always* make anonymous classes final. >> >>It makes very little sense to me that everyone needs to explicitly mark their anonymous >>classes as final just because there is a class_alias loophole that could, in theory, have been used >>to extend anonymous classes in the past. Especially given that there is no evidence of this >>"feature" being used in the wild (or if there is such evidence, it was not presented in >>the proposal). >> >>Regards, >>Nikita > I agree with this, and would also say that this RFC is the most thin > one I've seen. > > There is no reasoning, or examples, or pretty much anything else in it. I have also voted no for the same reasons as above. A more fleshed out RFC that goes default-final (which would then enable the engine optimizations mentioned) I would probably vote yes for. Though one could debate if that should be saved for 9.0 just to be safe. (Which I'd also be fine with.) --Larry Garfield