Re: Implement SeekableIterator for SplObjectStorage
| From: | Niels Dossche | Date: | Sun, 10 Mar 2024 21:58:31 +0000 |
| Subject: | Re: Implement SeekableIterator for SplObjectStorage | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-122607@lists.php.net to get a copy of this message | ||
Hi Bruce
On 10/03/2024 21:43, Bruce Weirdan wrote:
> On Sun, Mar 10, 2024 at 9:14 PM Niels Dossche <dossche.niels@gmail.com> wrote:
>
>> I opened a PR to make SplObjectStorage implement SeekableIterator, this means that
>> it'll now be possible to use
seek(int $offset): void on
>> SplObjectStorage
>
> Note that it's a BC break for descendants of SplObjectStorage with an
> incompatible seek() already implemented (e.g.
> https://3v4l.org/uW9Yl), so it shouldn't happen in a patch
> release.
Indeed, that's why the PR is targeted to the master branch, i.e. PHP 8.4 :)
> Not that I expect there to be many of those, but still.
>
>
>
> --
> Best regards,
> Bruce Weirdan
> mailto:weirdan@gmail.com
Kind regards
Niels