Re: cvs: php-src /ext/curl interface.c

From:	Dave Barr	Date:	Fri, 20 Aug 2004 01:06:33 +0000
Subject:	Re: cvs: php-src /ext/curl interface.c
References:	1	Groups:	php.internals
Request:	Send a blank email to internals+get-12276@lists.php.net to get a copy of this message

Ilia Alshanetsky wrote:

iliaa Thu Aug 19 20:55:56 2004 EDT
  Modified files:                  /php-src/ext/curl	interface.c   Log:
Added more missing cURL options. + REGISTER_CURL_CONSTANT(CURL_TIMECOND_IFMODSINCE); + REGISTER_CURL_CONSTANT(CURL_TIMECOND_IFUNMODSINCE); + REGISTER_CURL_CONSTANT(CURL_TIMECOND_LASTMOD);

Great, thanks!

+ case CURL_TIMECOND_IFMODSINCE: + case CURL_TIMECOND_IFUNMODSINCE: + case CURL_TIMECOND_LASTMOD: convert_to_long_ex(zvalue); error = curl_easy_setopt(ch->cp, option, Z_LVAL_PP(zvalue)); break;

I don't think the three constants belong here. This switch() is for CURLOPT_'s which these constants are not. These constants are for use with CURLOPT_TIMECONDITION. You would use them as such: curl_setopt($ch, CURLOPT_TIMECONDITION, CURL_TIMECOND_IFMODSINCE); curl_setopt($ch, CURLOPT_TIMECONDITION, CURL_TIMECOND_IFUNMODSINCE); curl_setopt($ch, CURLOPT_TIMECONDITION, CURL_TIMECOND_LASTMOD); Dave