Re: Re: [RFC] [Discussion] #[\Deprecated] attribute again v1.3

On Fri, May 17, 2024, at 9:53 AM, Benjamin Außenhofer wrote: > On Tue, Apr 23, 2024 at 3:27 PM Benjamin Außenhofer <kontakt@beberlei.de> wrote: >> Hi internals, >> >> My PR for #[\Deprecated] attribute was in hibernation for a long while now and after some >> off-list discussion a few weeks ago I have decided to revisit it and asked Tim to help me out with >> the work. >> >> Tim has cleaned up the PR quite a bit and also worked in additional features such as >> #[Deprecated] support in stub generation. >> >> While there are still some small todos, at this point we want to restart the discussion >> about the RFC for inclusion in 8.4: >> >> RFC: https://wiki.php.net/rfc/deprecated_attribute >> PR: https://github.com/php/php-src/pull/11293 >> Old discussion: https://externals.io/message/112554#112554 >> >> Let me know about your questions and feedback. > > Feedback period is now nearing 4 weeks and the last 2 have not brought > any new significant discussions, as such we plan to open the vote next > Wednesday if no new roadblocks come up. > > Thank you to all participants for the feedback. >> >> greetings >> Benjamin Why is the attribute not allowed on classes? I think it would make sense on every language structure, unrestricted. (Including classes, parameters, everything.) The user-space definition of the attribute is invalid in the example: It declares properties AND promoted constructor args. That can/should be combined. Otherwise, this looks good to me. --Larry Garfield