Re: [RFC] [discussion] Correctly name the rounding mode and make it an Enum
| From: | Gina P. Banyard | Date: | Thu, 13 Jun 2024 01:28:21 +0000 |
| Subject: | Re: [RFC] [discussion] Correctly name the rounding mode and make it an Enum | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-123591@lists.php.net to get a copy of this message | ||
On Tuesday, 11 June 2024 at 20:47, Tim Düsterhus <tim@bastelstu.be> wrote:
> Hi
>
> Am 2024-06-08 02:29, schrieb Saki Takamachi:
>
> > Regarding 1, personally, I support Gina's opinion of only providing
> > the new rounding modes as an Enum.
> > This can be interpreted as changing the rounding mode to Enum, with
> > the existing constants being kept simply for backward compatibility.
>
>
> I've talked about this with Saki in private. We both agree that
> providing the 4 new rounding modes only by means of the proposed
>
RoundingMode enum is the right choice. I have made the
> necessary
> adjustments to the RFC text. There is a new "Rounding Modes introduced
> in PHP 8.4" section that explains that the 4 constants will be removed
> as part of the RoundingMode enum RFC.
>
> Best regards
> Tim Düsterhus
Thank you, I think other than possibly prefixing the NegativeInfinity
and PositiveInfinity cases with "Towards" I am happy with the content
of the RFC.
Best regards,
Gina P. Banyard