Re: [RFC][Discussion] Enhance JSON error messages
| From: | juan carlos morales | Date: | Sun, 30 Jun 2024 14:52:06 +0000 |
| Subject: | Re: [RFC][Discussion] Enhance JSON error messages | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-124102@lists.php.net to get a copy of this message | ||
El El dom, 30 de jun. de 2024 a la(s) 11:15, Tim Düsterhus <tim@bastelstu.be>
escribió:
> Hi
>
> On 6/30/24 15:43, juan carlos morales wrote:
> > So, what I see here in my shortexperiencie is an RFC with 3 Options
>
> That is not an option. Each RFC needs a clear primary vote that is a
> "Yes/No" vote.
>
> > 1) Enhance the error message we already have
> >
> > 2) keep json_last_error_msg as it is and add a new function
> > json_last_error_info function
> >
> > 3) both
> >
>
> Adjusting error messages to make them better is not something that
> requires an RFC. We do this all the time without an RFC. Here's an
> example PR: https://github.com/php/php-src/pull/14496
>
> A new json_last_error_info() for easier programmatic access of the
> important bits can still be considered, but would not need an RFC either
> from my point of view. It's a simple and obvious addition. Those can be
> done without an RFC, unless someone complains.
>
> Best regards
> Tim Düsterhus
>
Ok , then, i will prepare 2 PRs and lets see what happens then.
Thanks.
I will let everybody know When ready