Re: [VOTE] Correctly name the rounding mode and make it an Enum
| From: | Tim Düsterhus | Date: | Fri, 05 Jul 2024 12:28:39 +0000 |
| Subject: | Re: [VOTE] Correctly name the rounding mode and make it an Enum | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-124228@lists.php.net to get a copy of this message | ||
Hi
On 7/3/24 08:32, Tim Düsterhus wrote:
RFC Text: https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum Discussion Thread: https://externals.io/message/123472I have just added a link to the implementation of the enum and the changes to
round() to the RFC. Saki will handle the changes to ext/bcmath.
You can find my PR at: https://github.com/php/php-src/pull/14833
I have also fixed an error in the explanation of the 'PositiveInfinity' rounding mode [1]. It previously read:
Round to the largest integer that is greater or equal.but it should read:
Round to the ***smallest*** integer that is greater or equal.I apologize for the confusion this may have caused. Best regards Tim Düsterhus [1] https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum?do=diff&rev2%5B0%5D=1720182318&rev2%5B1%5D=1720182387&difftype=sidebyside