Re: Sync CODEOWNERS
| From: | Saki Takamachi | Date: | Thu, 18 Jul 2024 12:40:39 +0000 |
| Subject: | Re: Sync CODEOWNERS | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-124473@lists.php.net to get a copy of this message | ||
Hi Christoph,
> Hi all!
>
> I have noticed that the CODEOWNERS of php-src are apparently not synced
> for all active branches[1][2]. However, it seems to me that this
> doesn't make sense; if someone provides a PR against some lower branch,
> the most recent CODEOWNERS may not be notified, and modifications might
> be send to possibly inactive maintainers. This is particularly
> confusing if the base branch of an PR will be changed; all over sudden
> new reviews may be requested.
>
> So I suggest to sync CODEOWNERS for all active branches (and maybe even
> security branches).
>
> What do you think?
>
> [1] <3p&{
> >f$https://github.com/php/php-src/blob/PHP-8.2/.github/CODEOWNERS>
> [2]
> <https://github.com/php/php-src/blob/master/.github/CODEOWNERS>
>
> Cheers,
> Christoph
From what I can see, the difference is mostly me....
I'm in favor of syncing.
Regards,
Saki