Re: Request for opinions: bug vs feature - change intokenization of yield from

On Sat, Jul 20, 2024, 9:31 AM Tim Düsterhus <tim@bastelstu.be> wrote: > Hi > > On 7/19/24 00:51, Christoph M. Becker wrote: > > And frankly, how much code would be affected? I mean, does anybody > > actually put a comment between yield and > > from? Is there a case > > where this may make sense? "Because we can" isn't a strong argument, in > > my opinion. > > I don't really follow this line of argumentation: > > If folks do not use the syntax anyways, then we do not need to have this > discussion, because the tools can just ignore it existing. That also > means we do not need to revert the change in PHP. > > If folks use the syntax, then reverting the change is a breaking change > for them. > By this line of reasoning, any bug that makes it into the engine that somebody finds a use for shouldn't be fixed. I totally understand wanting to keep this in, but because it made it in without an RFC, it's (a) inconsistent with other areas of the language, and (b) does not have a full design which includes tokenizer support. Considering the brief time it's been in the engine, and the fact that it's not documented, I feel it should be reverted and only re-added if someone takes the time and effort to propose the change properly. > >