Re: Deprecate ext/curl `CURLOPT_DNS_USE_GLOBAL_CACHE`?
| From: | Ayesh Karunaratne | Date: | Mon, 29 Jul 2024 11:09:07 +0000 |
| Subject: | Re: Deprecate ext/curl `CURLOPT_DNS_USE_GLOBAL_CACHE`? | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-124675@lists.php.net to get a copy of this message | ||
> Actually deprecating the constant might require the RFC process, so
> maybe it's best to make it a no-op for now (and to deprecate for PHP
> 8.5/9.0 whatever is next).
You are right I also think making this no-op is the best way for now.
Notably, Symfony HttpClient uses the constant to **disable** this
feature. So if we were to deprecate the constant, it will cause
deprecation notices unnecessarily.
>
> But regardless of deprecation or no-op'ing, we should document the
> behavior, and tell users about alternatives to accomplish the same goal.
I will submit PRs to the php/doc-en about the outcome of this change.
Thank you for weighing in on this. There is PR 5094[^1] from you that
proposed to deprecate several
CURLE_ constants. If we were to no-op
this constant, I'd like to propose a deprecation RFC with all those
changes combined.
Thank you,
Ayesh.
[^1]: https://github.com/php/php-src/pull/5094