Re: Should there be a `get_declared_enums()` function ?
| From: | Ayesh Karunaratne | Date: | Sat, 17 Aug 2024 04:26:11 +0000 |
| Subject: | Re: Should there be a `get_declared_enums()` function ? | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-125021@lists.php.net to get a copy of this message | ||
>
> I'm presuming it's too late for PHP 8.4, what with feature freeze having come &
> gone this week.
>
> Based on the mostly supportive responses on the list, I wonder whether an RFC is needed. If so,
> I'd be happy to create an initial draft (for PHP 8.5).
>
Thank you!
We now have the Release Cycle Update RFC approved
(https://wiki.php.net/rfc/release_cycle_update#allow_features_that_do_not_require_an_rfc_in_the_beta_period),
and it does allow minor new features during the beta period.
Quoting from the RFC:
> [snip]
> It therefore seems illogical to allow RFC-requiring features to be merged during the beta
> period, but not minor improvements that do not require an RFC, such as adding constant, parameters,
> config options, or even small functions or methods.
>
> We propose to explicitly allow minor features, optimizations, and internal API / ABI changes,
> during the beta period.
I think the
get_declared_enums is small enough to be considered a
minor change given we don't change any engine internals. Given the
positive response on the mailing list, I think we can have this in PHP
8.4 as well, subject to RMs approval of course. There's also a PR from
yesterday (https://github.com/php/php-src/pull/15446) that added a new
Curl constant.