Re: [DISCUSSION] Multibyte for levenshtein function

Hi Am 2024-09-25 09:21, schrieb youkidearitai:

I tried implement mb_levenshtein function and create an RFC. https://wiki.php.net/rfc/mb_levenshtein https://github.com/php/php-src/pull/16043 I would like discussion, feel free to comment.

Thank you for your RFC. I share the concern raised by cmb in the PR discussion: https://github.com/php/php-src/pull/16043#issuecomment-2374574538 Generally working with codepoints is going to be confusing for a user, but sometimes it is necessary when dealing with external systems that themselves work with codepoints (MySQL comes to my mind). However calculating the Levenshtein distance is most certainly something that purely is "user-facing" and not constrained by external systems. Calculating the distance of codepoints is going to be extremely confusing when dealing with things like Emoji. It would probably best to either only offer a grapheme_* function here or to leave this fully to userland. Best regards Tim Düsterhus