Re: Deprecate mhash constants?
| From: | Niels Dossche | Date: | Fri, 25 Oct 2024 19:32:39 +0000 |
| Subject: | Re: Deprecate mhash constants? | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-125866@lists.php.net to get a copy of this message | ||
On 25/10/2024 19:24, Christoph M. Becker wrote:
> Hi all,
>
> recently, it was discovered that although the mhash functions are
> deprecated as of PHP 8.1.0[1], the mhash constants are not yet
> deprecated. I believe that was just an oversight, since the are well
> hidden in the sources, and we don't even have them in the stub files[2].
>
> I made a PR to actually deprecate the constants[3]. Does anybody feel
> this needs the RFC process?
>
> [1]
> <https://wiki.php.net/rfc/deprecations_php_8_1#mhash_function_family>
> [2] <https://github.com/php/doc-en/issues/3902>
> [3] <https://github.com/php/php-src/pull/16569>
>
> Christoph
Since their intended use is deprecated, just deprecate them already too :)
Kind regards
Niels