Re: Adding attributes to compile-time constants
| From: | Larry Garfield | Date: | Tue, 26 Nov 2024 20:39:20 +0000 |
| Subject: | Re: Adding attributes to compile-time constants | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-126067@lists.php.net to get a copy of this message | ||
On Tue, Nov 26, 2024, at 2:15 PM, Daniel Scherzer wrote:
> Hi internals,
>
> For the last few weeks, I've been working on a patch[1] that I just
> uploaded that adds support for attributes on compile-time non-class
> constants (those declared with
const rather than via
> define()). The
> patch has a memory leak that I have been unable to resolve, but
> otherwise the functionality is there and seems to work. Is anyone
> willing to help with the memory issue?
>
> Separately, once the memory issue is fixed, would this need to go
> through an RFC process?
>
> Thanks,
> --Daniel Scherzer
>
> [1] https://github.com/php/php-src/pull/16952
I believe it would require an RFC, though I expect it would pass easily. I'm no help on the
memory question though, I'm afraid.
--Larry Garfield