Re: [VOTE] Attributes on Constants
| From: | Daniel Scherzer | Date: | Mon, 06 Jan 2025 03:22:19 +0000 |
| Subject: | Re: [VOTE] Attributes on Constants | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-126202@lists.php.net to get a copy of this message | ||
On Sat, Jan 4, 2025 at 4:03 PM Daniel Scherzer <daniel.e.scherzer@gmail.com>
wrote:
> > the vote will be open for 3 weeks given the holidays, closing on
> 2025-01-06 at 00:00:00 UTC.
>
> Just a reminder that this will close in 24 hours, if you can vote but
> haven't yet
>
> -Daniel
>
I have closed the RFC, final vote was 26 in favor and 0 against. The PR at
https://github.com/php/php-src/pull/16952
should be ready to merge, I've
cleaned up the merge conflicts and squashed the work. Since I don't have
the permissions to merge this myself, I would appreciate it if someone else
could merge the implementation.
Thanks,
-Daniel