Re: ext/sockets: socket_getpeername/socket_getsockname BC
| From: | David CARLIER | Date: | Wed, 29 Jan 2025 12:27:12 +0000 |
| Subject: | Re: ext/sockets: socket_getpeername/socket_getsockname BC | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-126231@lists.php.net to get a copy of this message | ||
Ok fair enough, will revert it.
Cheers.
On Wed, 29 Jan 2025 at 12:04, Jakub Zelenka <bukka@php.net> wrote:
>
>
>
> On Wed, Jan 29, 2025 at 4:22 AM David CARLIER <devnexen@gmail.com> wrote:
>>
>> Hi,
>>
>> Working on this PR #17440, I wanted to ask if the BC from these two calls
>> were ok because :
>>
>> Before
>>
>> function socket_getsockname(Socket $socket, &$address, &$port = null): bool {}
>>
>> After
>>
>> function socket_getsockname(Socket $socket, &$address, ?int &$objint = null): bool
>> {}
>>
>> As it is no longer only used for port but also for. interface address index in the case of
>> AF_PACKET.
>>
>
> Please no BC break. It's really not worth it.
>
> Cheers
>
> Jakub