Re: [RFC] Introducing pm.max_memory for PHP-FPM
| From: | Jakub Zelenka | Date: | Fri, 31 Jan 2025 10:26:05 +0000 |
| Subject: | Re: [RFC] Introducing pm.max_memory for PHP-FPM | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-126255@lists.php.net to get a copy of this message | ||
>
>
> To be honest, I haven't seen a 'slow' memory leak in a long time -- except
> when using fgetcsv which has had a reported memory leak since ~2012
> somewhere on the old bug tracker. (I lost the link to it and don't even
> remember how to get to the tracker or if it still exists.) I haven't
> checked if it has been fixed since 8.2, but I've seen a couple of reports
> of it on r/php a couple of times in the last couple of years.
>
I think it might still happen from time to time in external extensions.
Just recently Niels fixed this one
https://github.com/php/pecl-xml-xmldiff/pull/3
. In addition there can be
also a bug in an external library so it's not unlikely that there are still
many such cases.
Currently many people just have pm.max_requests in configuration for that
which is sometimes set to unnecessary low value. Having option that depends
on memory instead could reduce significantly the number of restarts - in
most cases probably to zero. In addition, it could also help to identify
that there is a leak which can get unnoticed if the users don't have alarms
on memory usage or just use pm.max_requests.
Regards
Jakub