Re: RFC: Marking return values as important (#[\NoDiscard])
| From: | Derick Rethans | Date: | Tue, 04 Feb 2025 11:10:51 +0000 |
| Subject: | Re: RFC: Marking return values as important (#[\NoDiscard]) | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-126283@lists.php.net to get a copy of this message | ||
On Wed, 29 Jan 2025, Tim Düsterhus wrote:
> Hi
>
> Volker and I would like to start discussion on our RFC to allow "Marking
> return values as important (#[\NoDiscard])".
>
> Please find the following resources for your reference:
>
> - RFC:
> https://wiki.php.net/rfc/marking_return_value_as_important
> - Implementation: https://github.com/php/php-src/pull/17599
Looks reasonable to me.
What's the reason why this emits a warning though, instead of throwing
an Exception? I'm sure you thought of it, but it would be nice to have
that consideration mentioned in the RFC.
cheers,
Derick