Re: Update OpenSSL Extension to Support KEMs
| From: | Kamil Tekiela | Date: | Thu, 13 Feb 2025 15:12:36 +0000 |
| Subject: | Re: Update OpenSSL Extension to Support KEMs | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-126393@lists.php.net to get a copy of this message | ||
I have no issue with adding more functions to the OpenSSL extension,
but they need to be very clearly documented and have an obvious API.
Cryptic names such as $pk or $sk cannot be used. While I really hate
array return types, if you must use it then it must be clearly
documented. It cannot just be "shared secret (typically 32 bytes)".
What does "typically" even mean? I assume the type for both would be a
string, but that's not obvious.
The OpenSSL documentation is in pretty bad shape. Many functions are
poorly documented and there are barely any examples. While I am sure
there are people who know how to use it, it's a complete mystery to me
and I presume many others.