RE: [PHP-DEV] small and probably dodgy fix

It missed the _define_. So if there was #define HAVE_STRCOLL 0 it'd be ok, but without the #define it's not ok. I'm just testing that now in case I'm wrong, but I don't think I am. > -----Original Message----- > From: Wez Furlong [mailto:kingwez@gmail.com] > Sent: 13 September 2004 16:01 > To: steph@zend.com > Cc: internals > Subject: Re: [PHP-DEV] small and probably dodgy fix > > > I meant that, on linux for example, if you manually undefined > HAVE_STRCOLL (to simulate not having it), will the build break? > > If so, then we need a real fix :-) > > --Wez. > > On Mon, 13 Sep 2004 16:11:10 +0100, Steph <steph@zend.com> wrote: > > no, there's only win32 and netware that have config files in > the Zend dir. > > > > I put it in the wrong place, it needs to be just ahead of the string.h > > include: > > > > --- zend_config.w32.h Mon Sep 13 15:17:16 2004 > > +++ zend_config.w32.h Mon Sep 13 15:27:16 2004 > > @@ -30,6 +30,8 @@ > > #include <stdlib.h> > > #include <crtdbg.h> > > > > +#define HAVE_STRCOLL 1 > > + > > #include <string.h> > > > > #ifndef ZEND_INCLUDE_FULL_WINDOWS_HEADERS > > > > > > > > > > > -----Original Message----- > > > From: Wez Furlong [mailto:kingwez@gmail.com] > > > Sent: 13 September 2004 15:54 > > > To: steph@zend.com > > > Cc: internals > > > Subject: Re: [PHP-DEV] small and probably dodgy fix > > > > > > > > > If that fixes it, doesn't that imply that other systems without > > > strcoll will also fail to build now? > > > (are there any that we care about?) > > > > > > --Wez. > > > > > > On Mon, 13 Sep 2004 15:21:14 +0100, Steph <steph@zend.com> wrote: > > > > Hi list, > > > > > > > > HEAD is broken for me following Derick's new sort flag > addition earlier > > > > today. > > > > > > > > The attached one-liner may be a wrong fix, neither self nor > D are sure. > > > > However it _does_ allow HEAD to build on my system! > > > > > > > > - Steph > > > > > > > > > > > > > > > > -- > > > > PHP Internals - PHP Runtime Development Mailing List > > > > To unsubscribe, visit: > > > > http://www.php.net/unsub.php > > > > > > > > > > > > > > > > > > > >