Re: [PATCH] ok this works in all cases and smells right
| From: | Wez Furlong | Date: | Mon, 13 Sep 2004 18:37:43 +0000 |
| Subject: | Re: [PATCH] ok this works in all cases and smells right | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-12774@lists.php.net to get a copy of this message | ||
On Mon, 13 Sep 2004 18:55:14 +0100, Steph <steph@zend.com> wrote:
> BTW shouldn't main/config.w32.h be in .cvsignore?
Ideally, yes, but it's still used as-is by the .dsp build system
Your patch looks much better (note that the # character for #define's
and #ifdefs etc. should start in the left-most column, otherwise some
weirdo compilers will break).
--Wez.