RE: [PHP-DEV] [PATCH] round 3
| From: | Steph | Date: | Tue, 14 Sep 2004 16:59:06 +0000 |
| Subject: | RE: [PHP-DEV] [PATCH] round 3 | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-12803@lists.php.net to get a copy of this message | ||
Yesterday that was a 'wrong fix' too :)
Please can you at least commit that so that the win32 build works as
advertised at least? You can worry about the mystery of other systems
breaking later.
> -----Original Message-----
> From: Derick Rethans [mailto:derick@php.net]
> Sent: 14 September 2004 17:21
> To: Steph
> Cc: internals
> Subject: Re: [PHP-DEV] [PATCH] round 3
>
>
> On Tue, 14 Sep 2004, Steph wrote:
>
> > Moved #if a few paces to the left on Wez's advice. Fussy old
> compilers ;)
> >
> > Still does the same job (fixes win32 build and all builds where
> there is no
> > strcoll), only this time without breaking otherwise happy builds.
>
> It's still wrong. The only change needed is the #define HAVE_STRCOLL in
> zend_config.w32.h
>
> Derick
>
> --
> Derick Rethans
> http://derickrethans.nl |
> http://ez.no | http://xdebug.org